Bug 213473

Summary: resultsdbpy: Make architecture differences explicit
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Description Jonathan Bedard 2020-06-22 11:54:47 PDT
Architecture used to be implied by platform, so we didn't display it in the UI. This is no longer the case.
Comment 1 Radar WebKit Bug Importer 2020-06-22 11:55:06 PDT
<rdar://problem/64602736>
Comment 2 Jonathan Bedard 2020-06-22 12:08:09 PDT
Created attachment 402489 [details]
Patch
Comment 3 Aakash Jain 2020-06-22 12:12:45 PDT
Comment on attachment 402489 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=402489&action=review

> Tools/resultsdbpy/resultsdbpy/view/static/js/configuration.js:183
> +            result += ' with ' + this.architecture;

Can you please provide an example of the use-case?
Comment 4 Jonathan Bedard 2020-06-22 13:14:28 PDT
(In reply to Aakash Jain from comment #3)
> Comment on attachment 402489 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=402489&action=review
> 
> > Tools/resultsdbpy/resultsdbpy/view/static/js/configuration.js:183
> > +            result += ' with ' + this.architecture;
> 
> Can you please provide an example of the use-case?

Mojave E Release on Macmini8,1 with x86_64

This is super important for Rosetta testing because a single model can actually run with multiple architectures.
Comment 5 Aakash Jain 2020-06-22 13:32:34 PDT
Comment on attachment 402489 [details]
Patch

rs=me
Comment 6 Jonathan Bedard 2020-06-22 13:37:34 PDT
Created attachment 402505 [details]
Patch for landing
Comment 7 EWS 2020-06-22 14:53:44 PDT
Committed r263367: <https://trac.webkit.org/changeset/263367>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 402505 [details].