| Summary: | [Win] fast/dom/Window/alert-with-unmatched-utf16-surrogate-should-not-crash.html is failing | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Fujii Hironori <Hironori.Fujii> | ||||||||||
| Component: | Tools / Tests | Assignee: | Fujii Hironori <Hironori.Fujii> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | darin, don.olmstead, pvollan, ross.kirsling, webkit-bug-importer, ysuzuki | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Fujii Hironori
2020-06-21 21:29:58 PDT
Created attachment 402443 [details]
Patch
Created attachment 402444 [details]
Patch
Created attachment 402445 [details]
Patch
Comment on attachment 402445 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=402445&action=review > Tools/DumpRenderTree/win/UIDelegate.cpp:458 > + // Return "(null)" for an invalid UTF-16 sequence Why not “invalid”? Not sure why we call an invalid sequence null. Comment on attachment 402445 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=402445&action=review >> Tools/DumpRenderTree/win/UIDelegate.cpp:458 >> + // Return "(null)" for an invalid UTF-16 sequence > > Why not “invalid”? Not sure why we call an invalid sequence null. WinCairo is supporting both WK1 and WK2. DRT should behave same with WTR. See Bug 213269 for WTR. Then the comment should say why. Generally speaking, comments purpose is to answer the question "why". The code itself answers the question "what". Created attachment 402495 [details]
Patch
(In reply to Darin Adler from comment #6) > Then the comment should say why. Generally speaking, comments purpose is to > answer the question "why". The code itself answers the question "what". Agreed. Fixed. Thank you. Comment on attachment 402495 [details]
Patch
Nice!
Comment on attachment 402495 [details] Patch Clearing flags on attachment: 402495 Committed r263379: <https://trac.webkit.org/changeset/263379> All reviewed patches have been landed. Closing bug. |