| Summary: | [WTF] URL should support dataLog | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Yusuke Suzuki <ysuzuki> | ||||||||
| Component: | New Bugs | Assignee: | Yusuke Suzuki <ysuzuki> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | benjamin, cdumez, cmarcelo, ews-watchlist, mark.lam, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Yusuke Suzuki
2020-06-21 19:26:49 PDT
Created attachment 402439 [details]
Patch
Created attachment 402440 [details]
Patch
Created attachment 402441 [details]
Patch
I need to admit that we should eventually merge TextStream (WebCore side thing) and PrintStream (WTF / JSC side thing) into one, but it requires a grand plan anyway :) Comment on attachment 402441 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=402441&action=review r=me with nit. > Source/WTF/wtf/URL.cpp:770 > +void URL::dump(PrintStream& out) const > +{ > + out.print(m_string); > +} nit: should we keep this definition in the header instead? If it's not normally used and we only need this for occasional debugging use, then it is more efficient to have it in the header vs explicitly putting it here. There a lot of other less commonly dumped data structures that do this also. Comment on attachment 402441 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=402441&action=review >> Source/WTF/wtf/URL.cpp:770 >> +} > > nit: should we keep this definition in the header instead? If it's not normally used and we only need this for occasional debugging use, then it is more efficient to have it in the header vs explicitly putting it here. There a lot of other less commonly dumped data structures that do this also. Discussed with Mark on Slack. We keep it as is to avoid including `#include <wtf/PrintStream.h>` in `URL.h`. Committed r263340: <https://trac.webkit.org/changeset/263340> All reviewed patches have been landed. Closing bug and clearing flags on attachment 402441 [details]. |