Bug 213437

Summary: RecoveryOS: PAL::getAVPlayerLayerClass() will crash when AVFoundation is missing
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, ews-watchlist, glenn, peng.liu6, philipj, sergio, simon.fraser, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
eric.carlson: review+
Patch for landing none

Description Jer Noble 2020-06-20 14:00:00 PDT 
RecoveryOS: PAL::getAVPlayerLayerClass() will crash when AVFoundation is missing
Comment 1 Radar WebKit Bug Importer 2020-06-20 14:02:15 PDT 
<rdar://problem/64563064>
Comment 2 Jer Noble 2020-06-20 14:04:16 PDT 
Created attachment 402401 [details]
Patch
Comment 3 Peng Liu 2020-06-20 14:18:51 PDT 
Comment on attachment 402401 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=402401&action=review

> Source/WebCore/platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm:1281
> +    if (PAL::isAVFoundationFrameworkAvailable())

Seems incorrect?
Comment 4 Eric Carlson 2020-06-20 14:46:46 PDT 
Comment on attachment 402401 [details]
Patch

r=me with the issue Peng point out changed
Comment 5 Jer Noble 2020-06-20 18:00:53 PDT 
Created attachment 402411 [details]
Patch for landing
Comment 6 Jer Noble 2020-06-20 18:11:02 PDT 
(In reply to Peng Liu from comment #3)
> Comment on attachment 402401 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=402401&action=review
> 
> > Source/WebCore/platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm:1281
> > +    if (PAL::isAVFoundationFrameworkAvailable())
> 
> Seems incorrect?

Good catch!
Comment 7 EWS 2020-06-20 19:49:31 PDT 
Committed r263323: <https://trac.webkit.org/changeset/263323>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 402411 [details].