Bug 213410

Summary:

[JSC] Check Gigacage usage before launching VM

Product:

WebKit

Reporter:

Yusuke Suzuki <ysuzuki>

Component:

New Bugs

Assignee:

Yusuke Suzuki <ysuzuki>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, cdumez, cmarcelo, ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	mark.lam: review+
Patch for landing	none
Patch for landing	none

Description Yusuke Suzuki 2020-06-19 15:36:28 PDT

[JSC] Check Gigacage usage before launching VM

Comment 1 Yusuke Suzuki 2020-06-19 15:39:05 PDT

Created attachment 402338 [details]
Patch

Comment 2 Yusuke Suzuki 2020-06-19 15:39:38 PDT

<rdar://problem/64023029>

Comment 3 Mark Lam 2020-06-19 16:23:30 PDT

Comment on attachment 402338 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=402338&action=review

r=me

> Source/WTF/wtf/Gigacage.h:74
> +ALWAYS_INLINE size_t size(Kind) { return 0; }
> +ALWAYS_INLINE size_t slidedSize(Kind) { return 0; }

Per our offline conversation, let's rename size() to maxSize() and slidedSize() to size().

Comment 4 Yusuke Suzuki 2020-06-19 16:44:26 PDT

Created attachment 402346 [details]
Patch for landing

Comment 5 Yusuke Suzuki 2020-06-19 17:41:04 PDT

composited-iframe-with-fixed-background-doc-repaint.html is failing in WK1 bot, but this is also failing in the other EWS tests (see https://ews-build.webkit.org/#/builders/30/builds/12264).

Comment 6 Yusuke Suzuki 2020-06-19 18:23:51 PDT

Created attachment 402366 [details]
Patch for landing

Comment 7 EWS 2020-06-19 21:20:56 PDT

Committed r263316: <https://trac.webkit.org/changeset/263316>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 402366 [details].