Bug 213409

Summary: Remove unnecessary Timer from NetworkDataTask
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Alex Christensen 2020-06-19 15:06:49 PDT 
Remove unnecessary Timer from NetworkDataTask
Comment 1 Alex Christensen 2020-06-19 15:09:52 PDT 
Created attachment 402332 [details]
Patch
Comment 2 youenn fablet 2020-06-23 06:27:30 PDT 
Comment on attachment 402332 [details]
Patch

Please make sure to fix GTK/WPE/WIN
Comment 3 Alex Christensen 2020-06-23 11:03:50 PDT 
Created attachment 402570 [details]
Patch
Comment 4 EWS 2020-06-23 11:41:13 PDT 
Committed r263407: <https://trac.webkit.org/changeset/263407>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 402570 [details].
Comment 5 Radar WebKit Bug Importer 2020-06-23 11:42:16 PDT 
<rdar://problem/64654646>
Comment 6 Darin Adler 2020-06-23 12:21:42 PDT 
Comment on attachment 402570 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=402570&action=review

> Source/WebKit/NetworkProcess/NetworkDataTask.cpp:100
> +        if (!weakThis || !m_client)
> +            return;

Is this a safe idiom? Do we have a guarantee that we are not racing with a deref of NetworkDataTask on another thread?
Comment 7 Alex Christensen 2020-06-23 13:58:00 PDT 
Comment on attachment 402570 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=402570&action=review

>> Source/WebKit/NetworkProcess/NetworkDataTask.cpp:100
>> +            return;
> 
> Is this a safe idiom? Do we have a guarantee that we are not racing with a deref of NetworkDataTask on another thread?

NetworkDataTask is always destroyed on the main thread because it uses WTF::DestructionThread::Main