Bug 213408

Summary:

[AutoSizing] Resolve viewport units against the preferred content size

Product:

WebKit

Reporter:

zalan <zalan>

Component:

Layout and Rendering

Assignee:

zalan <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, simon.fraser, thorton, timothy, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	ews-feeder: commit-queue-

Description zalan 2020-06-19 14:56:45 PDT

<rdar://problem/64267539>

Comment 1 zalan 2020-06-19 14:59:45 PDT

*** Bug 213313 has been marked as a duplicate of this bug. ***

Comment 2 zalan 2020-06-19 15:14:47 PDT

Created attachment 402333 [details]
Patch

Comment 3 Tim Horton 2020-06-19 15:26:10 PDT

Comment on attachment 402333 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=402333&action=review

> Source/WebCore/ChangeLog:19
> +        and resolved the values against the horiztonal constraint).

horiztonal

> Source/WebCore/testing/Internals.cpp:3716
> +void Internals::enableSizeToContentAutoSizeMode(bool enabled, int width, int height)

We already have tests. Maybe no internals method because they’re all API tests? OK

Comment 4 zalan 2020-06-19 15:30:20 PDT

Created attachment 402336 [details]
Patch

Comment 5 zalan 2020-06-19 15:31:59 PDT

> > Source/WebCore/testing/Internals.cpp:3716
> > +void Internals::enableSizeToContentAutoSizeMode(bool enabled, int width, int height)
> 
> We already have tests. Maybe no internals method because they’re all API
> tests? OK
Yeah, and we already have layout tests for the fixed-autosizing(mail), so I thought why not add one for the contentsize-autosizing.

Comment 6 zalan 2020-06-19 17:21:24 PDT

Created attachment 402354 [details]
Patch

Comment 7 EWS 2020-06-19 17:57:40 PDT

commit-queue failed to commit attachment 402354 [details] to WebKit repository.

Comment 8 zalan 2020-06-19 19:45:00 PDT

Committed r263311: <https://trac.webkit.org/changeset/263311>