Bug 213396

Summary: [iOS] RenderThemeIOS::cssValueToSystemColorMap() does an unnecessary linear search under systemColorFromCSSValueID()
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: changseok, dino, esprehn+autocc, ews-watchlist, ggaren, glenn, kondapallykalyan, pdr, pvollan, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=204314
Attachments:
Description Flags
Patch
none
Patch none

Description Chris Dumez 2020-06-19 11:52:11 PDT 
RenderThemeIOS::cssValueToSystemColorMap() does an unnecessary linear search under systemColorFromCSSValueID().
cssValueToSystemColorMap() already has the selector, yet it passes a CSSValueID to systemColorFromCSSValueID() which then does a linear search to match the CSSValueID to a selector.
Comment 1 Chris Dumez 2020-06-19 12:09:37 PDT 
Created attachment 402303 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2020-06-19 12:11:12 PDT 
<rdar://problem/64540057>
Comment 3 Chris Dumez 2020-06-19 12:17:26 PDT 
Created attachment 402304 [details]
Patch
Comment 4 EWS 2020-06-19 13:13:19 PDT 
Committed r263282: <https://trac.webkit.org/changeset/263282>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 402304 [details].