| Summary: | Make $vm properties non-configurable, non-enumerable, and non-writable. | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Mark Lam <mark.lam> | ||||||
| Component: | JavaScriptCore | Assignee: | Mark Lam <mark.lam> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | ews-watchlist, keith_miller, msaboff, saam, tzagallo, webkit-bug-importer, ysuzuki | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Mark Lam
2020-06-19 11:41:12 PDT
Created attachment 402300 [details]
proposed patch.
Comment on attachment 402300 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=402300&action=review > Source/JavaScriptCore/ChangeLog:3 > + Make $vm properties non-configurable, non-enumerable, and non-writable. say why Comment on attachment 402300 [details]
proposed patch.
r=me. Can we have a test that ensures Object.keys for $vm does not contain interesting keys?
Created attachment 402320 [details]
patch for landing.
Thanks for the reviews. Landed in r263283: <http://trac.webkit.org/r263283>. Why don't we just freeze $vm? |