Bug 213366

Summary: [ews] Add JSC-Only builders for MIPS and ARMv7 architectures
Product: WebKit Reporter: Diego Pino <dpino>
Component: New BugsAssignee: Diego Pino <dpino>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ews-watchlist, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=212009
https://bugs.webkit.org/show_bug.cgi?id=213503
https://bugs.webkit.org/show_bug.cgi?id=219444
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Description Diego Pino 2020-06-18 21:49:11 PDT
[ews] Add JSC-Only builders for MIPS and ARMv7 architectures
Comment 1 Diego Pino 2020-06-18 21:51:19 PDT
Created attachment 402268 [details]
Patch
Comment 2 Diego Pino 2020-06-19 01:35:33 PDT
Created attachment 402269 [details]
Patch
Comment 3 Aakash Jain 2020-06-22 05:13:17 PDT
Comment on attachment 402269 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=402269&action=review

r+ with minor changes.

> Tools/BuildSlaveSupport/ews-build/config.json:479
> +      "name": "JSC-Build-MIPSEL-32bits-EWS",

Let's rename this to JSC-MIPSEL-32bits-Build-EWS to match with other builders.

> Tools/BuildSlaveSupport/ews-build/config.json:500
> +      "name": "JSC-Build-ARMv7-32bits-EWS",

Let's rename this to JSC-ARMv7-32bits-Build-EWS to match with other builders.

> Tools/BuildSlaveSupport/ews-build/factories.py:140
>  class JSCTestsFactory(Factory):

Let's rename this to JSCBuildAndTestsFactory (maybe in separate patch).
Comment 4 Diego Pino 2020-06-22 12:33:06 PDT
Created attachment 402490 [details]
Patch
Comment 5 Diego Pino 2020-06-22 13:02:15 PDT
Created attachment 402504 [details]
Patch
Comment 6 EWS 2020-06-22 22:04:59 PDT
Committed r263384: <https://trac.webkit.org/changeset/263384>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 402504 [details].
Comment 7 Radar WebKit Bug Importer 2020-06-22 22:05:17 PDT
<rdar://problem/64624871>
Comment 8 Aakash Jain 2020-06-23 04:23:17 PDT
Restarted EWS server to pick up this change.
Comment 9 Aakash Jain 2020-06-23 05:06:09 PDT
Minor follow-up fix: https://trac.webkit.org/changeset/263392/webkit