| Summary: | Remove setVelocity() from PannerNode | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Clark Wang <clark_wang> | ||||||
| Component: | Web Audio | Assignee: | Clark Wang <clark_wang> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | cdumez, darin, eric.carlson, esprehn+autocc, ews-watchlist, glenn, jer.noble, kondapallykalyan, philipj, sergio, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 212611 | ||||||||
| Attachments: |
|
||||||||
|
Description
Clark Wang
2020-06-18 15:43:40 PDT
Created attachment 402253 [details]
Patch
Comment on attachment 402253 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=402253&action=review > Source/WebCore/ChangeLog:8 > + Re-baselined previous test that now passes with velocity removed. Changelog is missing an explanation of the change and a link to the relevant spec section. Comment on attachment 402253 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=402253&action=review > Source/WebCore/Modules/webaudio/PannerNode.cpp:307 > + const FloatPoint3D& sourceVelocity = FloatPoint3D(0, 0, 0); This seems a peculiar way to write this. Not even sure it has defined behavior. I think the FloatPoint3D object may be destroyed and the end of the full expression? Maybe this should just be: const FloatPoint32 listenerVelocity; But of course, this is also a constant that’s always zero and so we could simplify the code below. Created attachment 402289 [details]
Patch
Committed r263304: <https://trac.webkit.org/changeset/263304> All reviewed patches have been landed. Closing bug and clearing flags on attachment 402289 [details]. |