Bug 213311

Summary: REGRESSION (r263044): [macOS] TestWebKitAPI.TextManipulation.InsertingContentIntoAlreadyManipulatedContentCreatesTextManipulationItem is a flaky failure
Product: WebKit Reporter: Ryan Haddad <ryanhaddad>
Component: New BugsAssignee: Sihui Liu <sihui_liu>
Status: RESOLVED FIXED    
Severity: Normal CC: sihui_liu, webkit-bot-watchers-bugzilla, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=213156
Attachments:
Description Flags
Patch none

Description Ryan Haddad 2020-06-17 11:33:52 PDT 
TestWebKitAPI.TextManipulation.InsertingContentIntoAlreadyManipulatedContentCreatesTextManipulationItem is a flaky failure on macOS bots

    TestWebKitAPI.TextManipulation.InsertingContentIntoAlreadyManipulatedContentCreatesTextManipulationItem
        _RegisterApplication(), FAILED TO establish the default connection to the WindowServer, _CGSDefaultConnection() is NULL.
        
        /Volumes/Data/slave/mojave-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:2481
        Value of: foundNewItemAfterCompletingTextManipulation
          Actual: false
        Expected: true

https://results.webkit.org/?suite=api-tests&test=TestWebKitAPI.TextManipulation.InsertingContentIntoAlreadyManipulatedContentCreatesTextManipulationItem
Comment 1 Ryan Haddad 2020-06-17 11:34:41 PDT 
It looks like this started with https://trac.webkit.org/changeset/263044/webkit
Comment 2 Radar WebKit Bug Importer 2020-06-17 11:34:58 PDT 
<rdar://problem/64456413>
Comment 3 Ryan Haddad 2020-06-17 11:36:00 PDT 
The test was renamed as part of that commit, it doesn't look like it used to be flaky when it was called TestWebKitAPI.TextManipulation.InsertingContentIntoAlreadyManipulatedContentDoesNotCreateTextManipulationItem
Comment 4 Sihui Liu 2020-06-17 12:38:07 PDT 
Created attachment 402145 [details]
Patch
Comment 5 EWS 2020-06-17 15:46:55 PDT 
Committed r263186: <https://trac.webkit.org/changeset/263186>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 402145 [details].