| Summary: | Null check plugin.m_data before using it in PDFPlugin::ByteRangeRequest::completeUnconditionally | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||
| Component: | New Bugs | Assignee: | Alex Christensen <achristensen> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | beidson, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Alex Christensen
2020-06-17 10:33:47 PDT
Created attachment 402130 [details]
Patch
Comment on attachment 402130 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=402130&action=review > Source/WebKit/ChangeLog:7 > + Reviewed by NOBODY (OOPS!). No test? Comment on attachment 402130 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=402130&action=review >> Source/WebKit/ChangeLog:7 >> + Reviewed by NOBODY (OOPS!). > > No test? No test. I believe our crash logs justify this change, and Brady's comment in radar convinces me that this is an edge case happening during teardown. Comment on attachment 402130 [details]
Patch
No test in deed - one of those cases where it's obvious what's happening but not feasible to get it happening reliably for testing.
Committed r263169: <https://trac.webkit.org/changeset/263169> All reviewed patches have been landed. Closing bug and clearing flags on attachment 402130 [details]. |