| Summary: | Web Inspector: ASSERTION FAILED: decodedLength >= dataLength at WebCore::NetworkResourcesData::ResourceData::decodeDataToContent() | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Devin Rousso <hi> | ||||
| Component: | Web Inspector | Assignee: | Devin Rousso <hi> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | bburg, ews-watchlist, hi, inspector-bugzilla-changes, joepeck, mjs, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Attachments: |
|
||||||
|
Description
Devin Rousso
2020-06-16 16:52:47 PDT
Created attachment 402055 [details]
Patch
Comment on attachment 402055 [details]
Patch
Is it possible to add a test case for this?
(In reply to Maciej Stachowiak from comment #3) > Comment on attachment 402055 [details] > Patch > > Is it possible to add a test case for this? I'm not really sure what's to test here. The primary change/fix is just removing an incorrect `ASSERT` (specifically, it's possible for the decoded size of a resource to be smaller than its encoded size). Furthermore, this logic (meaning `m_contentSize`) only really starts taking effect once there's 200MB (`maximumResourcesContentSize`) of data being stored, at which point the oldest content is evicted. It exists just to make sure Web Inspector doesn't hold onto data forever, eventually crashing when we hit our 4GB limit. Committed r263231: <https://trac.webkit.org/changeset/263231> All reviewed patches have been landed. Closing bug and clearing flags on attachment 402055 [details]. |