Bug 213251

Summary:

Text manipulation should handle nested item boundary elements

Product:

WebKit

Reporter:

Wenson Hsieh <wenson_hsieh>

Component:

HTML Editing

Assignee:

Wenson Hsieh <wenson_hsieh>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bdakin, ews-watchlist, megan_gardner, mifenton, sihui_liu, thorton, webkit-bug-importer, wenson_hsieh

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	sihui_liu: review+
Patch for landing	none

Description Wenson Hsieh 2020-06-16 09:10:49 PDT

<rdar://problem/63371514>

Comment 1 Wenson Hsieh 2020-06-16 09:23:04 PDT

Created attachment 402011 [details]
Patch

Comment 2 Sihui Liu 2020-06-16 10:18:00 PDT

Comment on attachment 402011 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=402011&action=review

> Source/WebCore/editing/TextManipulationController.cpp:419
> +        bool crossedItemBoundary = false;

This boolean is probably not needed. addItemIfPossible does not add item when units is empty.

Comment 3 Wenson Hsieh 2020-06-16 10:35:51 PDT

(In reply to Sihui Liu from comment #2)
> Comment on attachment 402011 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=402011&action=review
> 
> > Source/WebCore/editing/TextManipulationController.cpp:419
> > +        bool crossedItemBoundary = false;
> 
> This boolean is probably not needed. addItemIfPossible does not add item
> when units is empty.

Good point! Removed crossedItemBoundary.

Comment 4 Wenson Hsieh 2020-06-16 10:40:02 PDT

Created attachment 402022 [details]
Patch for landing

Comment 5 EWS 2020-06-16 11:11:28 PDT

Committed r263101: <https://trac.webkit.org/changeset/263101>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 402022 [details].