Bug 213229

Summary:

Provide alternatively-named WKBrowsingContextGroup SPI

Product:

WebKit

Reporter:

Alex Christensen <achristensen>

Component:

New Bugs

Assignee:

Alex Christensen <achristensen>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, thorton, webkit-bug-importer, youennf

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

213092

Attachments:

Description	Flags
Patch	none
Patch	none

Description Alex Christensen 2020-06-15 21:12:04 PDT

Provide alternatively-named WKBrowsingContextGroup SPI

Comment 1 Alex Christensen 2020-06-15 21:14:36 PDT

Created attachment 401977 [details]
Patch

Comment 2 Alex Christensen 2020-06-15 21:15:02 PDT

Created attachment 401978 [details]
Patch

Comment 3 Tim Horton 2020-06-16 10:44:31 PDT

Comment on attachment 401978 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401978&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKBrowsingContextGroup.h:44
> +- (void)addUserScript:(NSString *)source baseURL:(NSURL *)baseURL includeMatchPatternStrings:(NSArray<NSString *> *)includeMatchPatternStrings excludeMatchPatternStrings:(NSArray<NSString *> *)excludeMatchPatternStrings injectionTime:(_WKUserScriptInjectionTime)injectionTime mainFrameOnly:(BOOL)mainFrameOnly;

Not sure "include match pattern strings" quite reads as a parseable phrase to me.

Comment 4 EWS 2020-06-16 10:57:23 PDT

Committed r263099: <https://trac.webkit.org/changeset/263099>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 401978 [details].

Comment 5 Radar WebKit Bug Importer 2020-06-16 10:58:20 PDT

<rdar://problem/64413468>