Bug 213221

Summary:

REGRESSION (r262643): DumpRenderTree at com.apple.WebCore: WebCore::Document::prepareCanvasesForDisplayIfNeeded

Product:

WebKit

Reporter:

Dean Jackson <dino>

Component:

New Bugs

Assignee:

Dean Jackson <dino>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, changseok, esprehn+autocc, ews-watchlist, graouts, gyuyoung.kim, kangil.han, kondapallykalyan, noam, simon.fraser, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	simon.fraser: review+

Description Dean Jackson 2020-06-15 16:10:24 PDT

REGRESSION (r262643): DumpRenderTree at com.apple.WebCore: WebCore::Document::prepareCanvasesForDisplayIfNeeded

Comment 1 Dean Jackson 2020-06-15 16:11:19 PDT

rdar://64260400

Comment 2 Dean Jackson 2020-06-15 16:22:07 PDT

Created attachment 401954 [details]
Patch

Comment 3 Simon Fraser (smfr) 2020-06-15 16:29:26 PDT

Comment on attachment 401954 [details]
Patch

I think you should split this into two patches.

Comment 4 Dean Jackson 2020-06-16 15:34:02 PDT

Created attachment 402049 [details]
Patch

Comment 5 Simon Fraser (smfr) 2020-06-16 15:48:31 PDT

Comment on attachment 402049 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=402049&action=review

> Source/WebCore/dom/Document.h:1601
> +    void clearCanvasPreparation(HTMLCanvasElement*);

I don't like how we have multiple ways we do this. There's generic Element::didMove... stuff, there's HTMLMediaElement::unregisterWithDocument(), Document::unregisterForCaptionPreferencesChangedCallbacks(), Document::unregisterArticleElement() etc.

We should add one overridable hook for elements that need to do custom document removal. Maybe not in this patch.

Comment 6 Dean Jackson 2020-06-16 17:49:07 PDT

Committed r263128: <https://trac.webkit.org/changeset/263128>