| Summary: | Multiple hypothesis testing should use False Discovery Rate instead of Bonferroni | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Saam Barati <saam> | ||||
| Component: | JavaScriptCore | Assignee: | Saam Barati <saam> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | ap, darin, mark.lam, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Saam Barati
2020-06-15 15:07:16 PDT
Created attachment 401961 [details]
patch
Comment on attachment 401961 [details]
patch
r=me
Committed r263114: <https://trac.webkit.org/changeset/263114> All reviewed patches have been landed. Closing bug and clearing flags on attachment 401961 [details]. Comment on attachment 401961 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=401961&action=review > Tools/Scripts/compare-results:181 > + isSignifcant = computeMultipleHypothesesSignficance(a, b) typo: "signifcant" (In reply to Darin Adler from comment #5) > Comment on attachment 401961 [details] > patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=401961&action=review > > > Tools/Scripts/compare-results:181 > > + isSignifcant = computeMultipleHypothesesSignficance(a, b) > > typo: "signifcant" Ah, I typod it twice! "Signficance" too Will fix |