Bug 213217

Summary: [iOS] Collecting screen properties in the UI process introduced a Safari launch time regression.
Product: WebKit Reporter: Per Arne Vollan <pvollan>
Component: WebKit Misc.Assignee: Per Arne Vollan <pvollan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, cdumez, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
bfulgham: review+
Patch none

Per Arne Vollan
Reported 2020-06-15 14:54:24 PDT
Calling collectScreenProperties() in WebProcessPool::platformInitializeWebProcess() introduced a Safari launch time regression on iOS.
Attachments
Patch (6.39 KB, patch)
2020-06-15 15:04 PDT, Per Arne Vollan 		bfulgham: review+
DetailsFormatted DiffDiff
Patch (6.42 KB, patch)
2020-06-15 16:05 PDT, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Per Arne Vollan
Comment 1 2020-06-15 15:03:27 PDT
rdar://problem/64374461
Per Arne Vollan
Comment 2 2020-06-15 15:04:29 PDT
Created attachment 401943 [details] Patch
Brent Fulgham
Comment 3 2020-06-15 16:01:33 PDT
Comment on attachment 401943 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=401943&action=review r=me > Source/WebCore/ChangeLog:4 > + https://bugs.webkit.org/show_bug.cgi?id=213217 <rdar://problem/64374461> > Source/WebCore/ChangeLog:11 > + the UI process. It's a shame this code has to differ between macOS and iOS.
Per Arne Vollan
Comment 4 2020-06-15 16:05:33 PDT
Created attachment 401952 [details] Patch
Per Arne Vollan
Comment 5 2020-06-15 16:06:12 PDT
(In reply to Brent Fulgham from comment #3) > Comment on attachment 401943 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=401943&action=review > > r=me > > > Source/WebCore/ChangeLog:4 > > + https://bugs.webkit.org/show_bug.cgi?id=213217 > > <rdar://problem/64374461> > Fixed. > > Source/WebCore/ChangeLog:11 > > + the UI process. > > It's a shame this code has to differ between macOS and iOS. Thanks for reviewing!
EWS
Comment 6 2020-06-16 08:00:40 PDT
Committed r263090: <https://trac.webkit.org/changeset/263090> All reviewed patches have been landed. Closing bug and clearing flags on attachment 401952 [details].
Note You need to log in before you can comment on or make changes to this bug.