Bug 213183

Summary:

[iOS] Two KeyboardInputTests are failing on recent iOS SDK versions

Product:

WebKit

Reporter:

Wenson Hsieh <wenson_hsieh>

Component:

Tools / Tests

Assignee:

Wenson Hsieh <wenson_hsieh>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bdakin, jbedard, megan_gardner, thorton, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Typo fix	none
Patch	thorton: review+
Highly speculative fix...	none
Patch for landing	none

Description Wenson Hsieh 2020-06-14 10:15:55 PDT

They are:

• KeyboardInputTests.CaretSelectionRectAfterRestoringFirstResponder
• KeyboardInputTests.RangedSelectionRectAfterRestoringFirstResponder

Comment 1 Wenson Hsieh 2020-06-14 10:16:57 PDT

<rdar://problem/64273483>

Comment 2 Wenson Hsieh 2020-06-14 10:42:31 PDT Comment hidden (obsolete)

Created attachment 401864 [details]
Patch

Comment 3 Wenson Hsieh 2020-06-14 10:47:59 PDT Comment hidden (obsolete)

Created attachment 401865 [details]
Typo fix

Comment 4 Wenson Hsieh 2020-06-14 10:50:57 PDT

Created attachment 401866 [details]
Patch

Comment 5 Wenson Hsieh 2020-06-14 11:52:17 PDT

For some reason, this causes KeyboardInputTests.CaretSelectionRectAfterRestoringFirstResponder to crash on iOS 13.4 :(

Need to either figure out why (or maybe just define out the test on 13.4, since trunk won't support it anyways).

Comment 6 Wenson Hsieh 2020-06-14 13:12:37 PDT

(In reply to Wenson Hsieh from comment #5)
> For some reason, this causes
> KeyboardInputTests.CaretSelectionRectAfterRestoringFirstResponder to crash
> on iOS 13.4 :(
> 
> Need to either figure out why (or maybe just define out the test on 13.4,
> since trunk won't support it anyways).

Unable to reproduce locally using the internal iOS 13.4 SDK (17E262).

Comment 7 Wenson Hsieh 2020-06-14 14:22:39 PDT

(In reply to Wenson Hsieh from comment #6)
> (In reply to Wenson Hsieh from comment #5)
> > For some reason, this causes
> > KeyboardInputTests.CaretSelectionRectAfterRestoringFirstResponder to crash
> > on iOS 13.4 :(
> > 
> > Need to either figure out why (or maybe just define out the test on 13.4,
> > since trunk won't support it anyways).
> 
> Unable to reproduce locally using the internal iOS 13.4 SDK (17E262).

Also unable to reproduce locally using the public iOS 13.5 SDK.

Guess I'm going to have to use EWS to debug this...

Comment 8 Wenson Hsieh 2020-06-14 15:19:14 PDT

Created attachment 401873 [details]
Highly speculative fix...

Comment 9 Wenson Hsieh 2020-06-14 16:02:42 PDT

Comment on attachment 401873 [details]
Highly speculative fix...

Looks like that was it.

Comment 10 EWS 2020-06-14 16:06:15 PDT

Committed r263014: <https://trac.webkit.org/changeset/263014>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 401873 [details].

Comment 11 Jonathan Bedard 2020-06-18 15:44:42 PDT

Reopening to attach new patch.

Comment 12 Jonathan Bedard 2020-06-18 15:44:43 PDT

Created attachment 402245 [details]
Patch for landing

Comment 13 EWS 2020-06-18 16:04:49 PDT

Committed r263241: <https://trac.webkit.org/changeset/263241>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 402245 [details].