| Summary: | Add a quirk to allow starting AudioContext if document was interacted | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||
| Component: | Media | Assignee: | youenn fablet <youennf> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | eric.carlson, ews-watchlist, glenn, jer.noble, philipj, sergio, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Local Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 260134 | ||||||||
| Attachments: |
|
||||||||
|
Description
youenn fablet
2020-06-12 02:30:58 PDT
Created attachment 401715 [details]
Patch
Comment on attachment 401715 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=401715&action=review > Source/WebCore/Modules/webaudio/AudioContext.cpp:1089 > +static bool isDocumentAllowingAutoplayWebAudio(const Document& document) Minor nit: "is ... allowing" isn't quite right. Maybe something like "documentAllowsWebAudioToAutoPlay", or "doesDocumentAllowWebAudioToAutoPlay"? Created attachment 401887 [details]
Patch for landing
Committed r263025: <https://trac.webkit.org/changeset/263025> All reviewed patches have been landed. Closing bug and clearing flags on attachment 401887 [details]. (In reply to Eric Carlson from comment #2) > Comment on attachment 401715 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=401715&action=review > > > Source/WebCore/Modules/webaudio/AudioContext.cpp:1089 > > +static bool isDocumentAllowingAutoplayWebAudio(const Document& document) > > Minor nit: "is ... allowing" isn't quite right. Maybe something like > "documentAllowsWebAudioToAutoPlay", or "doesDocumentAllowWebAudioToAutoPlay"? I chose shouldDocumentAllowWebAudioToAutoPlay |