| Summary: | [LFC][TFC] Add support for min/max-width | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | zalan <zalan> | ||||||
| Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
zalan
2020-06-11 20:53:21 PDT
Created attachment 401705 [details]
Patch
Comment on attachment 401705 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=401705&action=review > Source/WebCore/layout/blockformatting/BlockFormattingContext.cpp:401 > +ContentWidthAndMargin BlockFormattingContext::computedWidthAndMargin(const FloatingContext& floatingContext, const Box& layoutBox, const ConstraintsPair& constraintsPair) It is somewhat confusing to have both 'computeWidthAndMargin' and 'computedWidthAndMargin' functions. Maybe this could be 'computeContentWidthAndMargin' based on the return type? (In reply to Antti Koivisto from comment #2) > Comment on attachment 401705 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=401705&action=review > > > Source/WebCore/layout/blockformatting/BlockFormattingContext.cpp:401 > > +ContentWidthAndMargin BlockFormattingContext::computedWidthAndMargin(const FloatingContext& floatingContext, const Box& layoutBox, const ConstraintsPair& constraintsPair) > > It is somewhat confusing to have both 'computeWidthAndMargin' and > 'computedWidthAndMargin' functions. > > Maybe this could be 'computeContentWidthAndMargin' based on the return type? Good point. I think what I am going to do is move this function to geometry() where all the other computed* functions are. That would be inline with the current naming logic: *FormattingContext has the "void compute*" functions and they call the corresponding "Type Geometry::computed*" functions. Created attachment 401728 [details]
Patch
Committed r262951: <https://trac.webkit.org/changeset/262951> All reviewed patches have been landed. Closing bug and clearing flags on attachment 401728 [details]. |