Bug 213109

Summary: Add SPI to preconnect to a server
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, ggaren, jbedard, mjs, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch for landing none

Description Alex Christensen 2020-06-11 20:25:54 PDT 
Add SPI to preconnect to a server
Comment 1 Alex Christensen 2020-06-11 20:28:57 PDT 
Created attachment 401703 [details]
Patch
Comment 2 Geoffrey Garen 2020-06-11 20:35:02 PDT 
Comment on attachment 401703 [details]
Patch

r=me
Comment 3 Alex Christensen 2020-06-11 22:01:23 PDT 
Comment on attachment 401703 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401703&action=review

> Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp:1475
> -    if (!url.isValid() || !url.protocolIsInHTTPFamily() || SecurityOrigin::isLocalHostOrLoopbackIPAddress(url.host()))
> +    if (!url.isValid() || !url.protocolIsInHTTPFamily())

It looks like this change made some tests fail.  The use of isLocalHostOrLoopbackIPAddress was probably covering up some bugs.
Comment 4 Chris Dumez 2020-06-12 07:24:21 PDT 
(In reply to Alex Christensen from comment #3)
> Comment on attachment 401703 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=401703&action=review
> 
> > Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp:1475
> > -    if (!url.isValid() || !url.protocolIsInHTTPFamily() || SecurityOrigin::isLocalHostOrLoopbackIPAddress(url.host()))
> > +    if (!url.isValid() || !url.protocolIsInHTTPFamily())
> 
> It looks like this change made some tests fail.  The use of
> isLocalHostOrLoopbackIPAddress was probably covering up some bugs.

Yes, we totally added that because the basic HTTPServer in API tests did not like the preconnects.
Comment 5 Radar WebKit Bug Importer 2020-06-12 10:31:28 PDT 
<rdar://problem/64302572>
Comment 6 Maciej Stachowiak 2020-06-12 10:31:46 PDT 
<rdar://problem/64184412>
Comment 7 Alex Christensen 2020-06-12 13:33:27 PDT 
Fixing that separate issue in https://bugs.webkit.org/show_bug.cgi?id=213144
Comment 8 Alex Christensen 2020-06-12 16:59:00 PDT 
Created attachment 401805 [details]
Patch
Comment 9 Maciej Stachowiak 2020-06-15 11:04:04 PDT 
Preconnect test still seems to be failing with the latest change.
Comment 10 Alex Christensen 2020-06-15 13:01:48 PDT 
Created attachment 401925 [details]
Patch
Comment 11 EWS 2020-06-15 13:59:26 PDT 
Committed r263057: <https://trac.webkit.org/changeset/263057>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 401925 [details].
Comment 12 Jonathan Bedard 2020-06-18 15:36:20 PDT 
Reopening to attach new patch.
Comment 13 Jonathan Bedard 2020-06-18 15:36:21 PDT 
Created attachment 402244 [details]
Patch for landing
Comment 14 Jonathan Bedard 2020-06-18 15:37:10 PDT 
(In reply to Jonathan Bedard from comment #13)
> Created attachment 402244 [details]
> Patch for landing

Build fix for Catalyst.
Comment 15 EWS 2020-06-18 16:11:55 PDT 
Committed r263242: <https://trac.webkit.org/changeset/263242>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 402244 [details].