| Summary: | Replace uses of black/white list with block/allow list | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Saam Barati <saam> | ||||||
| Component: | JavaScriptCore | Assignee: | Saam Barati <saam> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | bburg, benjamin, ews-watchlist, fpizlo, ggaren, gskachkov, guijemont, hi, joepeck, keith_miller, mark.lam, msaboff, rmorisset, ross.kirsling, ticaiolima, tzagallo, webkit-bug-importer, ysuzuki | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | Other | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=214371 | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 213092 | ||||||||
| Attachments: |
|
||||||||
|
Description
Saam Barati
2020-06-11 11:05:05 PDT
Less important than just making the change but exclude/include might fit better too, depending on the context. Created attachment 401659 [details]
patch
Comment on attachment 401659 [details]
patch
r=me.
This patch modifies the inspector protocol generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-inspector-generator-tests --reset-results`) Comment on attachment 401659 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=401659&action=review > Source/JavaScriptCore/inspector/scripts/codegen/objc_generator.py:134 > + allowlist = set(ObjCGenerator.DOMAINS_TO_GENERATE) Capitalize the L to be consistent with how we do it elsewhere? > Source/JavaScriptCore/tools/FunctionAllowList.cpp:2 > + * Copyright (C) 2014, 2016, 2020 Apple Inc. All rights reserved. Just use "2014-2020" instead. > Source/JavaScriptCore/tools/FunctionAllowList.h:2 > + * Copyright (C) 2014, 2016, 2020 Apple Inc. All rights reserved. Ditto. Comment on attachment 401659 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=401659&action=review >> Source/JavaScriptCore/inspector/scripts/codegen/objc_generator.py:134 >> + allowlist = set(ObjCGenerator.DOMAINS_TO_GENERATE) > > Capitalize the L to be consistent with how we do it elsewhere? I should probably do allow_list to be consistent in this file. Comment on attachment 401659 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=401659&action=review Personally I'd vote for a lowercase "l", but whichever works. > Source/JavaScriptCore/tools/FunctionAllowList.h:35 > +class FunctionWhitelist { Seems like this file got renamed but its contents weren't updated? Comment on attachment 401659 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=401659&action=review >> Source/JavaScriptCore/tools/FunctionAllowList.h:35 >> +class FunctionAllowList { > > Seems like this file got renamed but its contents weren't updated? This is just bugzilla showing diff in two parts I believe Created attachment 401669 [details]
patch for landing
Committed r262928: <https://trac.webkit.org/changeset/262928> All reviewed patches have been landed. Closing bug and clearing flags on attachment 401669 [details]. R=me too. |