| Summary: | Add dependencies for Migrate Headers and Generate Export Files build phases | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Keith Rollin <krollin> | ||||||
| Component: | Tools / Tests | Assignee: | Keith Rollin <krollin> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | thorton, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 213067 | ||||||||
| Attachments: |
|
||||||||
|
Description
Keith Rollin
2020-06-11 04:03:15 PDT
Created attachment 401631 [details]
Uploading for reference; the work is incomplete -- still needs dependencies for Migrate Headers.
Created attachment 401710 [details]
Patch
I tested this by performing full and then incremental NULL builds with XCBuild on and off. I then applied the patch from Bug 213067 and performed two incremental builds. I checked the build output of each build to verify that the desired build steps were being performed. Most importantly, the build failure discovered in Bug 213067 was gone. Thanks, Keith! Committed r262935: <https://trac.webkit.org/changeset/262935> All reviewed patches have been landed. Closing bug and clearing flags on attachment 401710 [details]. |