Bug 213063

Summary: [Cocoa] Build callOnMainThread on WTF::RunLoop rather than on a timer
Product: WebKit Reporter: Geoffrey Garen <ggaren>
Component: New BugsAssignee: Geoffrey Garen <ggaren>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, ap, benjamin, cdumez, cmarcelo, darin, ews-watchlist, koivisto, Lawrence.j, sihui_liu, simon.fraser, thorton, tsavell, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=213146
Attachments:
Description Flags
Patch
none
Patch for landing
none
Patch for landing none

Geoffrey Garen
Reported 2020-06-10 20:23:22 PDT
[Cocoa] Build callOnMainThread on WTF::RunLoop rather than on a timer
Attachments
Patch (3.05 KB, patch)
2020-06-10 20:48 PDT, Geoffrey Garen 		no flags
DetailsFormatted DiffDiff
Patch for landing (2.30 KB, patch)
2020-06-18 12:44 PDT, Geoffrey Garen 		no flags
DetailsFormatted DiffDiff
Patch for landing (2.30 KB, patch)
2020-06-22 10:18 PDT, Geoffrey Garen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Geoffrey Garen
Comment 1 2020-06-10 20:48:40 PDT
Created attachment 401617 [details] Patch
Geoffrey Garen
Comment 2 2020-06-11 09:26:11 PDT
Comment on attachment 401617 [details] Patch cq+
EWS
Comment 3 2020-06-11 09:28:37 PDT
Committed r262904: <https://trac.webkit.org/changeset/262904> All reviewed patches have been landed. Closing bug and clearing flags on attachment 401617 [details].
Radar WebKit Bug Importer
Comment 4 2020-06-11 09:29:28 PDT
<rdar://problem/64257294>
Jason Lawrence
Comment 5 2020-06-12 14:58:30 PDT
Reverted r262904 for reason: This commit broke a test on Mac wk1 Debug. Committed r262977: <https://trac.webkit.org/changeset/262977>
Darin Adler
Comment 6 2020-06-13 14:09:46 PDT
I wonder which test it broke. I’m sure that information is somewhere an expert can immediately find it, but I don’t know where to look.
Simon Fraser (smfr)
Comment 7 2020-06-13 14:53:46 PDT
It looks like it made media/remoteplayback-target-availability.html flakey?
Geoffrey Garen
Comment 8 2020-06-14 16:37:05 PDT
inspector/canvas/create-context-webgpu.html => fail media/remoteplayback-target-availability.html => flakey fail if run after media/remoteplayback-prompt.html
Geoffrey Garen
Comment 9 2020-06-18 12:44:34 PDT
Created attachment 402228 [details] Patch for landing
EWS
Comment 10 2020-06-18 13:06:15 PDT
Committed r263223: <https://trac.webkit.org/changeset/263223> All reviewed patches have been landed. Closing bug and clearing flags on attachment 402228 [details].
Truitt Savell
Comment 11 2020-06-19 17:07:15 PDT
Reverted r263223 for reason: Broke compositing/video/video-border-radius-clipping.html on Mac release wk1 Committed r263299: <https://trac.webkit.org/changeset/263299>
Alexey Proskuryakov
Comment 12 2020-06-22 09:11:36 PDT
Regressed tests were rewritten to sidestep problems, but regressions on those tests are still not explained. I think that we need to understand why the changes are beneficial (or at least safe) before re-landing.
Geoffrey Garen
Comment 13 2020-06-22 10:13:06 PDT
(In reply to Alexey Proskuryakov from comment #12) > Regressed tests were rewritten to sidestep problems, but regressions on > those tests are still not explained. I think that we need to understand why > the changes are beneficial (or at least safe) before re-landing. It's unfortunate that you started this discussion in two different places. I responded to your comment in https://bugs.webkit.org/show_bug.cgi?id=213424, and I'm relanding the patch now, since it has been reviewed and it passes all tests.
Geoffrey Garen
Comment 14 2020-06-22 10:18:08 PDT
Created attachment 402485 [details] Patch for landing
EWS
Comment 15 2020-06-22 10:43:36 PDT
Committed r263357: <https://trac.webkit.org/changeset/263357> All reviewed patches have been landed. Closing bug and clearing flags on attachment 402485 [details].
Geoffrey Garen
Comment 16 2020-06-22 12:57:22 PDT
> It's unfortunate that you started this discussion in two different places. I > responded to your comment in https://bugs.webkit.org/show_bug.cgi?id=213424, I think I should have said "It's fortunate that you called attention to this topic in both places; now let's put the discussion in https://bugs.webkit.org/show_bug.cgi?id=213424".
Note You need to log in before you can comment on or make changes to this bug.