Bug 213045

Summary: REGRESSION(r262838): Broke WPE Debug build
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED INVALID    
Severity: Normal CC: dpino, pnormand, svillar, youennf
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 212470    
Attachments:
Description Flags
REVERT of r262838 none

Description Yusuke Suzuki 2020-06-10 13:12:59 PDT 
https://trac.webkit.org/changeset/262838 broke the build:
Broke WPE Debug build

This is an automatic bug report generated by webkitbot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests fail.
Comment 1 Yusuke Suzuki 2020-06-10 13:13:06 PDT 
Created attachment 401573 [details]
REVERT of r262838

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the revert will be successful.  This process takes approximately 15 minutes.

If you would like to land the revert faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID

where ATTACHMENT_ID is the ID of this attachment.
Comment 2 Philippe Normand 2020-06-10 13:14:32 PDT 
Besides the missing `use namespace WebCore;` in PlatformXROpenXR.cpp
there is this error in the generated bindings:

error: no viable conversion from 'WebCore::XRFrameRequestCallback::Identifier' (aka 'unsigned long') to 'JSC::PropertyName'                                                     
    m_data->invokeCallback(thisValue, args, JSCallbackData::CallbackType::Function, Identifier(), returnedException);
                                                                                    ^~~~~~~~~~~~