| Summary: | [css-grid] Reimport WPT tests removed in r262809 | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Oriol Brufau <obrufau> | ||||||
| Component: | Tools / Tests | Assignee: | Oriol Brufau <obrufau> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | clopez, ews-watchlist, jfernandez, rego, webkit-bug-importer, youennf | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Oriol Brufau
2020-06-10 09:43:24 PDT
Created attachment 401550 [details]
Patch
Created attachment 401594 [details]
Patch
Comment on attachment 401594 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=401594&action=review r=me, but please review the comment and change the expectations for that test accordingly. > LayoutTests/TestExpectations:1059 > +webkit.org/b/209461 imported/w3c/web-platform-tests/css/css-grid/grid-items/grid-item-dynamic-min-contribution-001.html [ Failure ] I think the usual way to import testharness tests is to have a -expected.txt file with several FAIL messages, instead of marking them as Failure in the TestExpectations file. As that way we'd realize when there's any single change regarding that test, while the other way around we'll only realize when the whole test starts to PASS. (In reply to Manuel Rego Casasnovas from comment #3) > I think the usual way to import testharness tests is to have a -expected.txt > file with several FAIL messages, instead of marking them as Failure in the > TestExpectations file. As that way we'd realize when there's any single > change regarding that test, while the other way around we'll only realize > when the whole test starts to PASS. The problem is that in a subtest, the height of the element becomes (wrongly) the height of the viewport. And the viewport has different heights in different platforms. So it would be messier. Well, maybe it's not the viewport height, but there is some variance. I was getting FAIL Minimum size: 300% assert_equals: height expected "300px" but got "5400px" but in an iOS emulator it was something different than 5400px. Committed r262901: <https://trac.webkit.org/changeset/262901> All reviewed patches have been landed. Closing bug and clearing flags on attachment 401594 [details]. |