Bug 213016

Summary: [buildbot] Add buildAndTest bot for WebKitGTK (GTK4)
Product: WebKit Reporter: Diego Pino <dpino>
Component: New BugsAssignee: Diego Pino <dpino>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, clopez, ews-watchlist, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=215623
Bug Depends on:    
Bug Blocks: 210100    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Diego Pino
Reported 2020-06-10 02:18:08 PDT
[buildbot] Add buildAndTest bot for WebKitGTK (GTK4)
Attachments
Patch (6.21 KB, patch)
2020-06-10 02:20 PDT, Diego Pino 		no flags
DetailsFormatted DiffDiff
Patch (6.27 KB, patch)
2020-06-13 03:16 PDT, Diego Pino 		no flags
DetailsFormatted DiffDiff
Patch (5.72 KB, patch)
2020-07-28 07:42 PDT, Diego Pino 		no flags
DetailsFormatted DiffDiff
Patch (5.30 KB, patch)
2020-11-12 23:32 PST, Diego Pino 		no flags
DetailsFormatted DiffDiff
Patch (5.28 KB, patch)
2020-11-15 17:29 PST, Diego Pino 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Diego Pino
Comment 1 2020-06-10 02:20:39 PDT
Created attachment 401524 [details] Patch
Diego Pino
Comment 2 2020-06-13 03:16:38 PDT
Created attachment 401832 [details] Patch
Diego Pino
Comment 3 2020-07-28 07:42:54 PDT
Created attachment 405356 [details] Patch
Carlos Alberto Lopez Perez
Comment 4 2020-08-27 07:07:11 PDT
Comment on attachment 405356 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=405356&action=review > Tools/BuildSlaveSupport/build.webkit.org-config/config.json:89 > + { "name": "gtk-linux-bot-16", "platform": "gtk" }, Unfortunately I landed r266208 without realizing about this patch before. And I already picked gtk-linux-bot-16 in r266208. Can you please change the worker index number here to gtk-linux-bot-18 ? > Tools/BuildSlaveSupport/build.webkit.org-config/config.json:354 > + "slavenames": ["gtk-linux-bot-16"] Ditto
Diego Pino
Comment 5 2020-11-12 23:32:20 PST
Created attachment 414005 [details] Patch
Carlos Alberto Lopez Perez
Comment 6 2020-11-13 05:42:35 PST
Comment on attachment 414005 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=414005&action=review > Tools/CISupport/build-webkit-org/factories.py:179 > +class BuildAndTestAllButJSCFactory(TestAllButJSCFactory): > + def getProduct(self): > + self.addStep(CompileWebKit()) instead of inheriting from TestAllButJSCFactory and re-defining getProduct I would do this instead: class BuildAndTestAllButJSCFactory(BuildAndTestFactory): JSCTestClass = None
Diego Pino
Comment 7 2020-11-15 17:29:09 PST
Created attachment 414185 [details] Patch
EWS
Comment 8 2020-11-17 22:37:39 PST
Committed r269945: <https://trac.webkit.org/changeset/269945> All reviewed patches have been landed. Closing bug and clearing flags on attachment 414185 [details].
Radar WebKit Bug Importer
Comment 9 2020-11-17 22:38:18 PST
<rdar://problem/71524618>
Note You need to log in before you can comment on or make changes to this bug.