Bug 21298

Summary: Make updateScrollbars cross-platform
Product: WebKit Reporter: Dave Hyatt <hyatt>
Component: PlatformAssignee: Dave Hyatt <hyatt>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 21083    
Attachments:
Description Flags
Patch
hyatt: review-
Patch #2
none
Patch #3 sam: review+

Dave Hyatt
Reported 2008-10-01 23:43:26 PDT
Make updateScrollbars cross-platform on ScrollView.
Attachments
Patch (38.25 KB, patch)
2008-10-01 23:46 PDT, Dave Hyatt 		hyatt: review-
DetailsFormatted DiffDiff
Patch #2 (58.83 KB, patch)
2008-10-02 00:04 PDT, Dave Hyatt 		no flags
DetailsFormatted DiffDiff
Patch #3 (58.76 KB, patch)
2008-10-02 00:06 PDT, Dave Hyatt 		sam: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Dave Hyatt
Comment 1 2008-10-01 23:46:17 PDT
Created attachment 24007 [details] Patch
Dave Hyatt
Comment 2 2008-10-01 23:50:24 PDT
Comment on attachment 24007 [details] Patch Never mind. I need to remove more code.
Dave Hyatt
Comment 3 2008-10-02 00:04:58 PDT
Created attachment 24008 [details] Patch #2
Dave Hyatt
Comment 4 2008-10-02 00:06:43 PDT
Created attachment 24009 [details] Patch #3
Sam Weinig
Comment 5 2008-10-02 00:38:05 PDT
Comment on attachment 24009 [details] Patch #3 + The ScrollView now implement ScrollbarClient, which means that there was a clash of windowClipRect methods from the s/implement/implements/ + } + } + else { + scrollsHorizontally = (hScroll == ScrollbarAuto) ? hasHorizontalScrollbar : (hScroll == ScrollbarAlwaysOn); The else should be on the same line as the }. + if (pageStep < 0) pageStep = clientWidth; This should be on two lines. + if (pageStep < 0) pageStep = clientHeight; As should this -// FIXME: ScrollViewPrivate will eventually be completely gone. It's already gone on Mac. -#if !PLATFORM(MAC) +// FIXME: ScrollViewPrivate will eventually be completely gone. I think this #if was incorrectly removed. Otherwise, looks nice. r=me.
Dave Hyatt
Comment 6 2008-10-02 11:24:17 PDT
Fixed in r37198.
Note You need to log in before you can comment on or make changes to this bug.