| Summary: | WebKitLegacy: Exclude NSURLConnectionSPI.h from watchOS | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jonathan Bedard <jbedard> | ||||
| Component: | Tools / Tests | Assignee: | Jonathan Bedard <jbedard> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | webkit-bug-importer, wenson_hsieh | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| See Also: |
https://bugs.webkit.org/show_bug.cgi?id=212718 https://bugs.webkit.org/show_bug.cgi?id=214004 |
||||||
| Attachments: |
|
||||||
|
Description
Jonathan Bedard
2020-06-08 17:16:45 PDT
Created attachment 401402 [details]
Patch
Committed r262764: <https://trac.webkit.org/changeset/262764> All reviewed patches have been landed. Closing bug and clearing flags on attachment 401402 [details]. Comment on attachment 401402 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=401402&action=review > Source/WebKitLegacy/mac/Misc/WebDownload.h:36 > +#import <pal/spi/cocoa/NSURLConnectionSPI.h> Hm...is it safe to import PAL headers like this? I don't think PAL headers were intended to be imported by clients outside of WebKit, since they use WTF macros like USE(). However, this is an SPI header that could (in theory) be imported by any internal Apple clients... Comment on attachment 401402 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=401402&action=review >> Source/WebKitLegacy/mac/Misc/WebDownload.h:36 >> +#import <pal/spi/cocoa/NSURLConnectionSPI.h> > > Hm...is it safe to import PAL headers like this? > > I don't think PAL headers were intended to be imported by clients outside of WebKit, since they use WTF macros like USE(). However, this is an SPI header that could (in theory) be imported by any internal Apple clients... I think your right. Verifying locally right now that we don't need this, I think I just needed to change the define guard. |