Bug 212940

Summary:

REGRESSION: [Safari Mojave for High Sierra] Accessing some of the featured pages on apple.com causes the webpage to crash

Product:

WebKit

Reporter:

Dean Jackson <dino>

Component:

WebGL

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dino, thorton, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	thorton: review+

Description Dean Jackson 2020-06-08 16:42:20 PDT

Seeing crashes on apple.com when using high-performance WebGL.

Comment 1 Dean Jackson 2020-06-08 16:43:02 PDT

rdar://63839405

Comment 2 Dean Jackson 2020-06-08 16:49:31 PDT

Created attachment 401399 [details]
Patch

Note: This patch is for the safari-609-branch, so won't apply cleanly here.

Comment 3 Tim Horton 2020-06-08 16:52:02 PDT

Comment on attachment 401399 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401399&action=review

> Source/WebCore/platform/graphics/mac/SwitchingGPUClient.h:35
> +    static bool hasSingleton() { return !!m_singleton; }

The alternative is "singletonIfExists()" or whatever. I think we have a pattern for this.

Comment 4 Dean Jackson 2020-06-08 17:02:37 PDT

Comment on attachment 401399 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401399&action=review

>> Source/WebCore/platform/graphics/mac/SwitchingGPUClient.h:35
>> +    static bool hasSingleton() { return !!m_singleton; }
> 
> The alternative is "singletonIfExists()" or whatever. I think we have a pattern for this.

I'll do that on trunk. Thanks.

Comment 5 Dean Jackson 2020-06-09 01:51:01 PDT

Committed r262783: <https://trac.webkit.org/changeset/262783>

Comment 6 Dean Jackson 2020-06-09 14:20:08 PDT

Committed r262811: <https://trac.webkit.org/changeset/262811>