| Summary: | TextManipulation should only convert text from Node's text content to tokens | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Sihui Liu <sihui_liu> | ||||||||
| Component: | HTML Editing | Assignee: | Sihui Liu <sihui_liu> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | ews-watchlist, mifenton, webkit-bug-importer, wenson_hsieh | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Sihui Liu
2020-06-08 15:32:16 PDT
Created attachment 401386 [details]
Patch
Created attachment 401408 [details]
Patch
Comment on attachment 401408 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=401408&action=review > Source/WebCore/editing/TextManipulationController.cpp:234 > + if (contiansDelimiter) { Nit - contiansDelimiter => containsDelimiter > Source/WebCore/editing/TextManipulationController.cpp:329 > +TextManipulationController::ManipulationUnit TextManipulationController::createUnit(const Vector<String>& text, Node* textNode) Maybe make this take `Node& textNode`, since we never expect it to be null? Created attachment 401419 [details]
Patch for landing
Committed r262778: <https://trac.webkit.org/changeset/262778> All reviewed patches have been landed. Closing bug and clearing flags on attachment 401419 [details]. |