Bug 212927

Summary: Removed unneeded POINTER_WIDTH macro from b3
Product: WebKit Reporter: Keith Miller <keith_miller>
Component: New BugsAssignee: Keith Miller <keith_miller>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, ews-watchlist, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch ysuzuki: review+, keith_miller: commit-queue-

Description Keith Miller 2020-06-08 15:17:51 PDT
Removed unneeded POINTER_WIDTH macro from b3
Comment 1 Keith Miller 2020-06-08 15:19:08 PDT
Created attachment 401381 [details]
Patch
Comment 2 Darin Adler 2020-06-08 15:42:00 PDT
Comment on attachment 401381 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401381&action=review

> Source/JavaScriptCore/b3/B3Width.h:46
> +constexpr inline Width pointerWidth()

constexpr implies inline, so we never have to say both

https://en.cppreference.com/w/cpp/language/constexpr
Comment 3 Keith Miller 2020-06-08 15:45:02 PDT
Comment on attachment 401381 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401381&action=review

>> Source/JavaScriptCore/b3/B3Width.h:46
>> +constexpr inline Width pointerWidth()
> 
> constexpr implies inline, so we never have to say both
> 
> https://en.cppreference.com/w/cpp/language/constexpr

I was wondering if I needed both... I'll remove the inline.
Comment 4 Keith Miller 2020-06-08 15:46:25 PDT
Committed r262746: <https://trac.webkit.org/changeset/262746>
Comment 5 Radar WebKit Bug Importer 2020-06-08 15:47:23 PDT
<rdar://problem/64138322>