| Summary: | Extended Color: Rename Color::lighten() and Color::darken() to Color::lightened() and Color::darkened() | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Sam Weinig <sam> | ||||||||
| Component: | New Bugs | Assignee: | Sam Weinig <sam> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | changseok, darin, esprehn+autocc, ews-watchlist, glenn, kondapallykalyan, pdr, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Sam Weinig
2020-06-08 13:24:07 PDT
Created attachment 401365 [details]
Patch
Tools/Scripts/svn-apply failed to apply attachment 401365 [details] to trunk.
Please resolve the conflicts and upload a new patch.
Created attachment 401391 [details]
Patch
ChangeLog entry in Tools/ChangeLog contains OOPS!. Created attachment 401393 [details]
Patch
Comment on attachment 401393 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=401393&action=review > Tools/TestWebKitAPI/Tests/WebCore/ColorTests.cpp:222 > + auto cLigtened = Color(c).lightened().toSRGBASimpleColorLossy(); typo in existing code: "ligtened" (In reply to Darin Adler from comment #6) > Comment on attachment 401393 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=401393&action=review > > > Tools/TestWebKitAPI/Tests/WebCore/ColorTests.cpp:222 > > + auto cLigtened = Color(c).lightened().toSRGBASimpleColorLossy(); > > typo in existing code: "ligtened" Gaaaaa :). I'll get it right one of these times. Committed r262753: <https://trac.webkit.org/changeset/262753> All reviewed patches have been landed. Closing bug and clearing flags on attachment 401393 [details]. |