| Summary: | All platforms should enable CFPrefs read only mode in the WebContent process | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Per Arne Vollan <pvollan> | ||||
| Component: | WebKit Misc. | Assignee: | Per Arne Vollan <pvollan> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | benjamin, bfulgham, cdumez, cmarcelo, darin, ews-watchlist, thorton, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Per Arne Vollan
2020-06-08 12:33:00 PDT
Created attachment 401358 [details]
Patch
Comment on attachment 401358 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=401358&action=review > Source/WTF/wtf/PlatformHave.h:646 > + || ((PLATFORM(IOS) || PLATFORM(MACCATALYST)) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 140000) \ How certain are you that IPHONE_OS_VERSION is the right one to check in macCatalyst? (I think it's not, but I am not 100%) (In reply to Tim Horton from comment #2) > Comment on attachment 401358 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=401358&action=review > > > Source/WTF/wtf/PlatformHave.h:646 > > + || ((PLATFORM(IOS) || PLATFORM(MACCATALYST)) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 140000) \ > > How certain are you that IPHONE_OS_VERSION is the right one to check in > macCatalyst? (I think it's not, but I am not 100%) It is! Disregard me. Comment on attachment 401358 [details]
Patch
Thanks for reviewing!
Committed r262805: <https://trac.webkit.org/changeset/262805> All reviewed patches have been landed. Closing bug and clearing flags on attachment 401358 [details]. |