Bug 212905

Summary: [Flatpak][GStreamer] enhance GST_ environment variable passing
Product: WebKit Reporter: Víctor M. Jáquez L. <vjaquez>
Component: Tools / TestsAssignee: Víctor M. Jáquez L. <vjaquez>
Status: RESOLVED FIXED    
Severity: Normal CC: pnormand, webkit-bug-importer, zan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Víctor M. Jáquez L. 2020-06-08 08:57:55 PDT
Particulary GST_DEBUG is passed twice, and the used one is quoted, which avoids the correct parsing in GStreamer.
Comment 1 Víctor M. Jáquez L. 2020-06-08 09:36:51 PDT
Created attachment 401346 [details]
Patch
Comment 2 Philippe Normand 2020-06-08 11:05:04 PDT
Comment on attachment 401346 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401346&action=review

> Tools/ChangeLog:10
> +        quotes, but they break the parsing in GStreamer.

Break what? GST_DEBUG="foo*:5" is expanded to something else?
Comment 3 Víctor M. Jáquez L. 2020-06-08 11:49:00 PDT
Comment on attachment 401346 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401346&action=review

>> Tools/ChangeLog:10
>> +        quotes, but they break the parsing in GStreamer.
> 
> Break what? GST_DEBUG="foo*:5" is expanded to something else?

as if * were escaped and considered as a letter.
Comment 4 Philippe Normand 2020-06-09 01:24:04 PDT
env GST_DEBUG="webkit*:6" run-minibrowser --gtk LayoutTests/media/content/test.mp4

Works as expected here.
Comment 5 EWS 2020-06-09 01:34:00 PDT
Committed r262782: <https://trac.webkit.org/changeset/262782>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 401346 [details].
Comment 6 Radar WebKit Bug Importer 2020-06-09 01:34:15 PDT
<rdar://problem/64154995>
Comment 7 Radar WebKit Bug Importer 2020-06-09 01:34:16 PDT
<rdar://problem/64154996>