| Summary: | Shrink __DATA by making more intended const things const for real. | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Mark Lam <mark.lam> | ||||||||
| Component: | JavaScriptCore | Assignee: | Mark Lam <mark.lam> | ||||||||
| Status: | ASSIGNED --- | ||||||||||
| Severity: | Normal | CC: | bburg, benjamin, calvaris, cdumez, changseok, cmarcelo, dbarton, eric.carlson, esprehn+autocc, ews-watchlist, fred.wang, glenn, gyuyoung.kim, hi, jer.noble, jiewen_tan, joepeck, keith_miller, kondapallykalyan, mifenton, msaboff, pdr, philipj, saam, sergio, toyoshim, tzagallo, ysuzuki, yutak | ||||||||
| Priority: | P2 | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Mark Lam
2020-06-07 20:53:40 PDT
Created attachment 401308 [details]
proposed patch.
This patch modifies the inspector protocol generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-inspector-generator-tests --reset-results`) Created attachment 401310 [details]
proposed patch.
Created attachment 401339 [details]
proposed patch.
It looks to me now like the WinEWS bot is running with stale code. The error message says: WebCore.lib(UnifiedSource-84c9f43f-3.obj) : error LNK2001: unresolved external symbol "__declspec(dllimport) public: static char const * const Inspector::Protocol::CSS::CSSProperty::Priority" (__imp_?Priority@CSSProperty@CSS@Protocol@Inspector@@2PEBDEB) [C:\cygwin\home\buildbot\worker\Windows-EWS\build\WebKitBuild\Release\Source\WebKitLegacy\WebKitLegacy.vcxproj] WebCore.lib(UnifiedSource-84c9f43f-3.obj) : error LNK2001: unresolved external symbol "__declspec(dllimport) public: static char const * const Inspector::Protocol::CSS::CSSProperty::ParsedOk" (__imp_?ParsedOk@CSSProperty@CSS@Protocol@Inspector@@2PEBDEB) [C:\cygwin\home\buildbot\worker\Windows-EWS\build\WebKitBuild\Release\Source\WebKitLegacy\WebKitLegacy.vcxproj] WebCore.lib(UnifiedSource-84c9f43f-3.obj) : error LNK2001: unresolved external symbol "__declspec(dllimport) public: static char const * const Inspector::Protocol::CSS::CSSProperty::Status" (__imp_?Status@CSSProperty@CSS@Protocol@Inspector@@2PEBDEB) [C:\cygwin\home\buildbot\worker\Windows-EWS\build\WebKitBuild\Release\Source\WebKitLegacy\WebKitLegacy.vcxproj] WebCore.lib(UnifiedSource-84c9f43f-6.obj) : error LNK2001: unresolved external symbol "__declspec(dllimport) public: static char const * const Inspector::Protocol::Network::Response::MimeType" (__imp_?MimeType@Response@Network@Protocol@Inspector@@2PEBDEB) [C:\cygwin\home\buildbot\worker\Windows-EWS\build\WebKitBuild\Release\Source\WebKitLegacy\WebKitLegacy.vcxproj] C:\cygwin\home\buildbot\worker\Windows-EWS\build\WebKitBuild\Release\bin64\WebKit.dll : fatal error LNK1120: 4 unresolved externals [C:\cygwin\home\buildbot\worker\Windows-EWS\build\WebKitBuild\Release\Source\WebKitLegacy\WebKitLegacy.vcxproj] C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\MSBuild\Microsoft\VC\v160\Microsoft.CppCommon.targets(810,5): error MSB6006: "link.exe" exited with code 1120. [C:\cygwin\home\buildbot\worker\Windows-EWS\build\WebKitBuild\Release\Source\WebKitLegacy\WebKitLegacy.vcxproj] However, we don't even generate any line of code with "static char const * const Inspector::Protocol::CSS::CSSProperty::Priority" in it anymore. Comment on attachment 401339 [details]
proposed patch.
Taking out of review for now. The size test results actually showed a regression contrary to my expectation. This needs more investigation.
|