Bug 212855

Summary: WebKitLegacy: Link to framework stubs for watchOS and tvOS
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, ap, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=212718
Attachments:
Description Flags
Patch none

Description Jonathan Bedard 2020-06-05 16:16:10 PDT 
WebKitLegacy should link to framework stubs for watchOS and tvOS.
Comment 1 Radar WebKit Bug Importer 2020-06-05 16:16:29 PDT 
<rdar://problem/64049486>
Comment 2 Jonathan Bedard 2020-06-05 16:26:19 PDT 
Created attachment 401214 [details]
Patch
Comment 3 Tim Horton 2020-06-05 16:41:13 PDT 
Comment on attachment 401214 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401214&action=review

> Source/WebKitLegacy/mac/Configurations/WebKitLegacy.xcconfig:42
> +FRAMEWORK_SEARCH_PATHS[sdk=embedded*] = $(BUILT_PRODUCTS_DIR) $(WK_PRIVATE_FRAMEWORKS_DIR);
> +FRAMEWORK_SEARCH_PATHS[sdk=macosx*] = $(WK_QUOTED_OVERRIDE_FRAMEWORKS_DIR) "$(UMBRELLA_FRAMEWORKS_DIR)";

I think you're changing macCatalyst here (macCatalyst being "Cocoa Touch" but also sdk=macosx* is the reason I removed all the SDK conditionals back in the day). Maybe it's OK?
Comment 4 Jonathan Bedard 2020-06-06 06:41:45 PDT 
(In reply to Tim Horton from comment #3)
> Comment on attachment 401214 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=401214&action=review
> 
> > Source/WebKitLegacy/mac/Configurations/WebKitLegacy.xcconfig:42
> > +FRAMEWORK_SEARCH_PATHS[sdk=embedded*] = $(BUILT_PRODUCTS_DIR) $(WK_PRIVATE_FRAMEWORKS_DIR);
> > +FRAMEWORK_SEARCH_PATHS[sdk=macosx*] = $(WK_QUOTED_OVERRIDE_FRAMEWORKS_DIR) "$(UMBRELLA_FRAMEWORKS_DIR)";
> 
> I think you're changing macCatalyst here (macCatalyst being "Cocoa Touch"
> but also sdk=macosx* is the reason I removed all the SDK conditionals back
> in the day). Maybe it's OK?

I plan on look at getting Catalyst building next. It seems to me that Catalyst should be using Mac framework stubs, although that's something we'll need to decide.
Comment 5 EWS 2020-06-06 06:53:44 PDT 
Committed r262676: <https://trac.webkit.org/changeset/262676>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 401214 [details].