Bug 212834

Summary: WebCore: Link to framework stubs for watchOS and tvOS
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: WebCore Misc.Assignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, ap, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=212718
Attachments:
Description Flags
Patch
none
Patch none

Description Jonathan Bedard 2020-06-05 10:06:27 PDT 
WebCore should link to framework stubs for watchOS and tvOS.
Comment 1 Radar WebKit Bug Importer 2020-06-05 10:08:08 PDT 
<rdar://problem/64033712>
Comment 2 Jonathan Bedard 2020-06-05 10:36:49 PDT 
Created attachment 401173 [details]
Patch
Comment 3 Tim Horton 2020-06-05 11:13:07 PDT 
Comment on attachment 401173 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401173&action=review

> Source/WebCore/Configurations/Base.xcconfig:79
> +GCC_WARN_64_TO_32_BIT_CONVERSION[arch=i386] = NO;

Wonder why we have it on at all at this point. Also, how did we not need this when we had 32-bit macOS builds?
Comment 4 Tim Horton 2020-06-05 11:14:40 PDT 
Comment on attachment 401173 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401173&action=review

> Source/WebCore/Configurations/WebCore.xcconfig:38
> +FRAMEWORK_SEARCH_PATHS = $(WK_QUOTED_OVERRIDE_FRAMEWORKS_DIR) $(BUILT_PRODUCTS_DIR) $(WK_PRIVATE_FRAMEWORKS_DIR);

This seems a little out-of-scope. I can't imagine the harm (you should find what you're looking for in WK_QUOTED_OVERRIDE_FRAMEWORKS_DIR), but it is a significant change for macOS.
Comment 5 Jonathan Bedard 2020-06-05 11:25:38 PDT 
Comment on attachment 401173 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401173&action=review

>> Source/WebCore/Configurations/Base.xcconfig:79
>> +GCC_WARN_64_TO_32_BIT_CONVERSION[arch=i386] = NO;
> 
> Wonder why we have it on at all at this point. Also, how did we not need this when we had 32-bit macOS builds?

My first thought was to actually fix the issues, there aren't very many. But most of them are in automatically generated code, so the fixes may have had other side effects. If we want to keep this on, it seems better to get EWS up and running first.

>> Source/WebCore/Configurations/WebCore.xcconfig:38
>> +FRAMEWORK_SEARCH_PATHS = $(WK_QUOTED_OVERRIDE_FRAMEWORKS_DIR) $(BUILT_PRODUCTS_DIR) $(WK_PRIVATE_FRAMEWORKS_DIR);
> 
> This seems a little out-of-scope. I can't imagine the harm (you should find what you're looking for in WK_QUOTED_OVERRIDE_FRAMEWORKS_DIR), but it is a significant change for macOS.

I guess wee really want this:

FRAMEWORK_SEARCH_PATHS[sdk=embeedded*] = $(WK_QUOTED_OVERRIDE_FRAMEWORKS_DIR) $(BUILT_PRODUCTS_DIR) $(WK_PRIVATE_FRAMEWORKS_DIR);
FRAMEWORK_SEARCH_PATHS[sdk=macosx*] = $(WK_QUOTED_OVERRIDE_FRAMEWORKS_DIR);
Comment 6 Jonathan Bedard 2020-06-05 12:49:56 PDT 
Created attachment 401189 [details]
Patch
Comment 7 EWS 2020-06-05 13:40:27 PDT 
Committed r262650: <https://trac.webkit.org/changeset/262650>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 401189 [details].