Bug 212831

Summary: WebCore: Guard variable declarations on ENABLE(VIDEO_PRESENTATION_MODE)
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: WebCore Misc.Assignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, ap, cdumez, changseok, eric.carlson, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, jer.noble, peng.liu6, philipj, sergio, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=212718
Attachments:
Description Flags
Patch none

Description Jonathan Bedard 2020-06-05 09:52:12 PDT 
m_isEnteringOrExitingPictureInPicture and m_isWaitingForPictureInPictureWindowFrame are only used if VIDEO_PRESENTATION_MODE is enabled, no reason to declare these variable on platforms with VIDEO_PRESENTATION_MODE disabled.
Comment 1 Radar WebKit Bug Importer 2020-06-05 09:52:35 PDT 
<rdar://problem/64033028>
Comment 2 Jonathan Bedard 2020-06-05 10:00:00 PDT 
Created attachment 401166 [details]
Patch
Comment 3 Tim Horton 2020-06-05 10:29:01 PDT 
IMO you can land things like this as "build fixes" without review if you want.
Comment 4 Jonathan Bedard 2020-06-05 10:38:06 PDT 
(In reply to Tim Horton from comment #3)
> IMO you can land things like this as "build fixes" without review if you
> want.

There aren't many this trivial, I'm trying separate these into small enough changes that roll-outs for breaking other builds won't be too painful.
Comment 5 EWS 2020-06-05 10:56:02 PDT 
Committed r262633: <https://trac.webkit.org/changeset/262633>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 401166 [details].
Comment 6 Peng Liu 2020-06-05 11:00:18 PDT 
Comment on attachment 401166 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401166&action=review

> Source/WebCore/html/HTMLVideoElement.h:136
>      bool m_isChangingPresentationMode { false };

And this variable as well :-)
Comment 7 Jonathan Bedard 2020-06-05 14:07:38 PDT 
Comment on attachment 401166 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401166&action=review

>> Source/WebCore/html/HTMLVideoElement.h:136
>>      bool m_isChangingPresentationMode { false };
> 
> And this variable as well :-)

Actually, m_isChangingPresentationMode is used in webkitDisplayingFullscreen, which isn't guarded by ENABLE(VIDEO_PRESENTATION_MODE).
Comment 8 Peng Liu 2020-06-05 14:22:00 PDT 
Comment on attachment 401166 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401166&action=review

>>> Source/WebCore/html/HTMLVideoElement.h:136
>>>      bool m_isChangingPresentationMode { false };
>> 
>> And this variable as well :-)
> 
> Actually, m_isChangingPresentationMode is used in webkitDisplayingFullscreen, which isn't guarded by ENABLE(VIDEO_PRESENTATION_MODE).

Oh right!