Bug 212828

Summary: [ macOS wk1 ] http/tests/media/reload-after-dialog.html is a flaky failure
Product: WebKit Reporter: Jacob Uphoff <jacob_uphoff>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, hector_i_lopez, tsavell, webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Jacob Uphoff 2020-06-05 09:04:34 PDT 
http/tests/media/reload-after-dialog.html

This test recently became a flaky failure on macOS wk1 and the first instance of this was on r262524

History:

https://results.webkit.org/?suite=layout-tests&test=http%2Ftests%2Fmedia%2Freload-after-dialog.html

Diff:

--- /Volumes/Data/slave/catalina-debug-tests-wk2/build/layout-test-results/inspector/heap/getRemoteObject-expected.txt
+++ /Volumes/Data/slave/catalina-debug-tests-wk2/build/layout-test-results/inspector/heap/getRemoteObject-actual.txt
@@ -18,6 +18,8 @@
 -- Running test case: GetRemoteObjectCollectedObject
 PASS: Should not have an error creating a snapshot.
 PASS: Should should include at least one 'Map' instance.
-PASS: Should get an error when object has been collected.
-PASS: No object for identifier, it may have been collected
+FAIL: Should get an error when object has been collected.
+    Expected: truthy
+    Actual: null
+PASS: null
Comment 1 Jacob Uphoff 2020-06-05 09:12:11 PDT 
Set expectations here: https://trac.webkit.org/changeset/262624/webkit
Comment 2 Radar WebKit Bug Importer 2020-06-05 09:26:19 PDT 
<rdar://problem/64031923>
Comment 3 Alexey Proskuryakov 2020-06-07 13:55:51 PDT 
The above diff is wrong, it's for bug 212776.

I'm not sure if this issue is real, I only see a few failures on runs hundreds of tests failed.

> Set expectations here: https://trac.webkit.org/changeset/262624/webkit

You also updated expectations for yet another test in this commit, was it intentional?
Comment 4 Hector Lopez 2020-07-15 14:58:03 PDT 
Created attachment 404395 [details]
Patch
Comment 5 EWS 2020-07-15 15:26:00 PDT 
Committed r264430: <https://trac.webkit.org/changeset/264430>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 404395 [details].