Bug 212817

Summary:

[GTK] MiniBrowser: stop using GtkToolbar for the search bar

Product:

WebKit

Reporter:

Carlos Garcia Campos <cgarcia>

Component:

WebKitGTK

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aperez, bugs-noreply

Priority:

Keywords:

Gtk

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

210100, 210276, 212898

Attachments:

Description	Flags
Patch	aperez: review+

Description Carlos Garcia Campos 2020-06-05 06:00:07 PDT

Use a GtkSearchBar instead, because GtkToolbar is no longer available in GTK4.

Comment 1 Carlos Garcia Campos 2020-06-05 06:03:14 PDT

Created attachment 401144 [details]
Patch

Comment 2 Adrian Perez 2020-06-11 07:15:10 PDT

Comment on attachment 401144 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401144&action=review

LGTM, but please fix the typos before landing :)

> Tools/MiniBrowser/gtk/BrowserSearchBar.c:71
> +    action = g_action_map_lookup_action(G_ACTION_MAP(actionGroup), "beginnig-word");

Typo: beginnig → beginning.

(The same type is around in a few places more, I won't point out every instance.)

Comment 3 Carlos Garcia Campos 2020-06-12 01:26:06 PDT

Committed r262937: <https://trac.webkit.org/changeset/262937>