| Summary: | WTF: Exclude MachExceptions.defs from all embedded builds | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jonathan Bedard <jbedard> | ||||||
| Component: | Web Template Framework | Assignee: | Jonathan Bedard <jbedard> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | aestes, ap, thorton, webkit-bug-importer, wenson_hsieh | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=212718 | ||||||||
| Attachments: |
|
||||||||
|
Description
Jonathan Bedard
2020-06-04 19:58:53 PDT
Created attachment 401113 [details]
Patch
Comment on attachment 401113 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=401113&action=review > Source/WTF/ChangeLog:10 > +2020-06-04 Jonathan Bedard <jbedard@apple.com> Extra change log. > Source/WTF/Configurations/WTF.xcconfig:-35 > -SYSTEM_FRAMEWORK_SEARCH_PATHS = $(inherited) $(SDKROOT)$(SYSTEM_LIBRARY_DIR)/PrivateFrameworks This seems unrelated. > Source/WTF/Configurations/WTF.xcconfig:32 > +EXCLUDED_SOURCE_FILE_NAMES[sdk=embedded*] = $(EXCLUDED_SOURCE_FILE_NAMES_$(USE_INTERNAL_SDK)); This includes simulator, correct? Created attachment 401117 [details]
Patch
(In reply to Alexey Proskuryakov from comment #2) > Comment on attachment 401113 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=401113&action=review > > > Source/WTF/ChangeLog:10 > > +2020-06-04 Jonathan Bedard <jbedard@apple.com> > > Extra change log. > > > Source/WTF/Configurations/WTF.xcconfig:-35 > > -SYSTEM_FRAMEWORK_SEARCH_PATHS = $(inherited) $(SDKROOT)$(SYSTEM_LIBRARY_DIR)/PrivateFrameworks > > This seems unrelated. > > > Source/WTF/Configurations/WTF.xcconfig:32 > > +EXCLUDED_SOURCE_FILE_NAMES[sdk=embedded*] = $(EXCLUDED_SOURCE_FILE_NAMES_$(USE_INTERNAL_SDK)); > > This includes simulator, correct? It does, this same pattern will show up a few more times in other xcconfig files. Committed r262597: <https://trac.webkit.org/changeset/262597> All reviewed patches have been landed. Closing bug and clearing flags on attachment 401117 [details]. |