| Summary: | AsyncGenerator should await "return" completions | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alexey Shvayka <ashvayka> | ||||||||
| Component: | JavaScriptCore | Assignee: | Alexey Shvayka <ashvayka> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Minor | CC: | ews-watchlist, joepeck, keith_miller, mark.lam, msaboff, ross.kirsling, saam, tzagallo, webkit-bug-importer, ysuzuki | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | All | ||||||||||
| OS: | All | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Alexey Shvayka
2020-06-04 13:17:51 PDT
Created attachment 401070 [details]
Patch
Created attachment 401162 [details]
Patch
Rebase patch.
Comment on attachment 401162 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=401162&action=review > Source/JavaScriptCore/ChangeLog:9 > + This change implements step 8 of AsyncGeneratorYield [1] and step 7.c.iii.1 > + of yield* runtime semantics [2], aligning JSC with V8 and SpiderMonkey. Can you explain more? The pointed spec text is not so clear to this change. Created attachment 401651 [details]
Patch
Add detailed explanation to ChangeLog.
Comment on attachment 401651 [details]
Patch
LGTM, now that I took the time to wrap my head around it. :)
Committed r262979: <https://trac.webkit.org/changeset/262979> All reviewed patches have been landed. Closing bug and clearing flags on attachment 401651 [details]. (In reply to Ross Kirsling from comment #5) > Comment on attachment 401651 [details] > Patch > > LGTM, now that I took the time to wrap my head around it. :) This one is quite tricky: I've made a few unsuccessful attempts of adding Awaits here and there before discovering the hook at step 8. Thank you, Ross! |