Bug 212774

Summary: AsyncGenerator should await "return" completions
Product: WebKit Reporter: Alexey Shvayka <ashvayka>
Component: JavaScriptCoreAssignee: Alexey Shvayka <ashvayka>
Status: RESOLVED FIXED    
Severity: Minor CC: ews-watchlist, joepeck, keith_miller, mark.lam, msaboff, ross.kirsling, saam, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Alexey Shvayka
Reported 2020-06-04 13:17:51 PDT
AsyncGenerator should await "return" completions
Attachments
Patch (8.72 KB, patch)
2020-06-04 13:19 PDT, Alexey Shvayka 		no flags
DetailsFormatted DiffDiff
Patch (8.67 KB, patch)
2020-06-05 09:32 PDT, Alexey Shvayka 		no flags
DetailsFormatted DiffDiff
Patch (9.45 KB, patch)
2020-06-11 09:15 PDT, Alexey Shvayka 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Alexey Shvayka
Comment 1 2020-06-04 13:19:52 PDT
Created attachment 401070 [details] Patch
Alexey Shvayka
Comment 2 2020-06-05 09:32:28 PDT
Created attachment 401162 [details] Patch Rebase patch.
Yusuke Suzuki
Comment 3 2020-06-08 09:09:39 PDT
Comment on attachment 401162 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=401162&action=review > Source/JavaScriptCore/ChangeLog:9 > + This change implements step 8 of AsyncGeneratorYield [1] and step 7.c.iii.1 > + of yield* runtime semantics [2], aligning JSC with V8 and SpiderMonkey. Can you explain more? The pointed spec text is not so clear to this change.
Alexey Shvayka
Comment 4 2020-06-11 09:15:44 PDT
Created attachment 401651 [details] Patch Add detailed explanation to ChangeLog.
Ross Kirsling
Comment 5 2020-06-12 15:10:27 PDT
Comment on attachment 401651 [details] Patch LGTM, now that I took the time to wrap my head around it. :)
EWS
Comment 6 2020-06-12 15:13:23 PDT
Committed r262979: <https://trac.webkit.org/changeset/262979> All reviewed patches have been landed. Closing bug and clearing flags on attachment 401651 [details].
Radar WebKit Bug Importer
Comment 7 2020-06-12 15:14:17 PDT
<rdar://problem/64313960>
Alexey Shvayka
Comment 8 2020-06-12 15:18:28 PDT
(In reply to Ross Kirsling from comment #5) > Comment on attachment 401651 [details] > Patch > > LGTM, now that I took the time to wrap my head around it. :) This one is quite tricky: I've made a few unsuccessful attempts of adding Awaits here and there before discovering the hook at step 8. Thank you, Ross!
Note You need to log in before you can comment on or make changes to this bug.