Bug 212766

Summary: svn-apply command is too slow with big patches
Product: WebKit Reporter: Carlos Alberto Lopez Perez <clopez>
Component: Tools / TestsAssignee: Carlos Alberto Lopez Perez <clopez>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, achristensen, ap, cdumez, darin, dbates, ddkilzer, Hironori.Fujii, jbedard, lmoura, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Carlos Alberto Lopez Perez 2020-06-04 11:26:32 PDT 
I noticed that the tool we use to apply patches (svn-apply) its too slow with large patches.

Check: https://ews.webkit.org/status-bubble/400882
^ click on any of the mac/ios/wpe/gtk bubbles and see how much time it took the step "apply patch"

It took all the EWS systems between 8 and 12 hours!!! to apply that patch.

I admit that the patch in question <https://bugs.webkit.org/attachment.cgi?id=400882> is big (52MB; 29856 files changed), but the time spent to apply it is completely crazy.

This is also not only an issue for the EWS, but also for the commit-queue and for the "webkit-patch land-from-bug" command. Since all of them rely on the script svn-apply to apply patches
Comment 1 Carlos Alberto Lopez Perez 2020-06-04 11:47:49 PDT 
Created attachment 401058 [details]
Patch
Comment 2 Carlos Alberto Lopez Perez 2020-06-04 12:44:37 PDT 
Comment on attachment 401058 [details]
Patch

Clearing flags on attachment: 401058

Committed r262559: <https://trac.webkit.org/changeset/262559>
Comment 3 Carlos Alberto Lopez Perez 2020-06-04 12:44:42 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2020-06-04 12:45:18 PDT 
<rdar://problem/63991044>