Bug 212717

Summary:

Pause during ANGLE roll script after rebasing and before deleting temporary Git repo

Product:

WebKit

Reporter:

Kenneth Russell <kbr>

Component:

ANGLE

Assignee:

Kenneth Russell <kbr>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dino, ews-watchlist, graouts, jdarpinian, justin_fan, kondapallykalyan, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

214897

Attachments:

Description	Flags
Patch	none

Description Kenneth Russell 2020-06-03 15:13:37 PDT

jdarpinian@'s Source/ThirdParty/ANGLE/update-angle.sh script is extremely helpful - it automates nearly all of the steps of updating ANGLE in WebKit.

It would be useful if the script paused after the rebase phase, and after generating changes.diff, but before deleting the temporary git repository it creates in Source/ThirdParty/ANGLE. That way, any undesired changes compared to upstream ANGLE could be more easily removed. Currently there are a large number of apparently unnecessary changes which make it difficult to identify the salient diffs.

Would it be possible to add this feature to the roll script?

Comment 1 Kenneth Russell 2020-07-28 12:27:59 PDT

Taking this.

Comment 2 Kenneth Russell 2020-07-28 14:47:06 PDT

Created attachment 405418 [details]
Patch

Comment 3 EWS Watchlist 2020-07-28 14:47:57 PDT

Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE

Comment 4 Kenneth Russell 2020-07-28 14:49:21 PDT

This patch also slightly changes the user interface of the roll script to expect the user to press enter after confirming (y/n) whether to continue. I found it surprising on multiple occasions that the script went ahead immediately upon pressing the "y" key.

Comment 5 James Darpinian 2020-07-28 14:51:07 PDT

Looks good to me! I was thinking that the script would exit to let you poke around but this is much easier to implement and I think just as useful.

Comment 6 Kenneth Russell 2020-07-28 15:35:49 PDT

Thanks for your review James. I also thought of exiting the script but this was a lot easier to implement since it doesn't need any state management. It turned out to be useful during the ANGLE roll I'm currently doing in Bug 214897 - it caught one bad merge during rebase, and another important fix to upstream to ANGLE (Bug 213479, http://crbug.com/angleproject/4902 ).

Comment 7 EWS 2020-07-28 16:56:17 PDT

Committed r265023: <https://trac.webkit.org/changeset/265023>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 405418 [details].

Comment 8 Radar WebKit Bug Importer 2020-07-28 16:57:17 PDT

<rdar://problem/66245284>