Bug 212699

Summary: [iOS] Hide the PiP button in fullscreen mode if PiP is disabled in preferences
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, peng.liu6, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
eric.carlson: review+
Patch for landing
none
Patch for landing none

Description Jer Noble 2020-06-03 09:05:58 PDT 
[iOS] Hide the PiP button in fullscreen mode if PiP is disabled in preferences
Comment 1 Jer Noble 2020-06-03 09:07:38 PDT 
<rdar://problem/60391437>
Comment 2 Jer Noble 2020-06-03 09:10:27 PDT 
Created attachment 400924 [details]
Patch
Comment 3 Eric Carlson 2020-06-03 09:13:55 PDT 
Comment on attachment 400924 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=400924&action=review

> Source/WebKit/ChangeLog:22
> +2020-05-29  Jer Noble  <jer.noble@apple.com>
> +
> +        [Cocoa] EME should return more helpful error code during key exchange
> +        https://bugs.webkit.org/show_bug.cgi?id=212535
> +
> +        Reviewed by NOBODY (OOPS!).
> +

Oops!
Comment 4 Jer Noble 2020-06-03 09:29:30 PDT 
Created attachment 400929 [details]
Patch for landing
Comment 5 Jer Noble 2020-06-03 09:49:11 PDT 
Created attachment 400933 [details]
Patch for landing
Comment 6 EWS 2020-06-03 12:45:59 PDT 
Committed r262508: <https://trac.webkit.org/changeset/262508>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 400933 [details].