Bug 212694

Summary: REGRESSION: (r262456): [ Mac ] media/modern-media-controls/media-controller/media-controller-inline-to-fullscreen-to-pip-to-inline.html is timing out.
Product: WebKit Reporter: Jason Lawrence <Lawrence.j>
Component: MediaAssignee: Peng Liu <peng.liu6>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, ews-watchlist, glenn, jer.noble, peng.liu6, philipj, sergio, webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Mac   
OS: macOS 10.15   
See Also: https://bugs.webkit.org/show_bug.cgi?id=202425
Attachments:
Description Flags
Patch none

Description Jason Lawrence 2020-06-03 07:19:40 PDT 
media/modern-media-controls/media-controller/media-controller-inline-to-fullscreen-to-pip-to-inline.html

Description:
This test is timing out consistently on Mac. There were some timeouts on Mojave wk1, but the issue appears to have started or become exacerbated on 06/02/2020.

History:
https://results.webkit.org/?suite=layout-tests&test=media%2Fmodern-media-controls%2Fmedia-controller%2Fmedia-controller-inline-to-fullscreen-to-pip-to-inline.html&limit=50000

Diff:
--- /Volumes/Data/slave/catalina-release-tests-wk2/build/layout-test-results/media/modern-media-controls/media-controller/media-controller-inline-to-fullscreen-to-pip-to-inline-expected.txt
+++ /Volumes/Data/slave/catalina-release-tests-wk2/build/layout-test-results/media/modern-media-controls/media-controller/media-controller-inline-to-fullscreen-to-pip-to-inline-actual.txt
@@ -1,25 +1,5 @@
-Testing that entering fullscreen, then going into picture-in-picture and then going back to inline presents inline controls.
+#PID UNRESPONSIVE - WebKitTestRunner (pid 79148)
+FAIL: Timed out waiting for notifyDone to be called
 
-On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-
-
-
-Media started playing, we pause it and enter fullscreen by clicking on the matching button.
-PASS shadowRoot.querySelector('.media-controls').classList.contains('inline') is true
-
-Media received a webkitpresentationmodechanged event, media.webkitPresentationMode = fullscreen.
-PASS shadowRoot.querySelector('.media-controls').classList.contains('fullscreen') is true
-
-We enter picture-in-picture by clicking on the matching button.
-
-Media received a webkitpresentationmodechanged event, media.webkitPresentationMode = picture-in-picture.
-
-We exit picture-in-picture.
-
-Media received a webkitpresentationmodechanged event, media.webkitPresentationMode = inline.
-PASS shadowRoot.querySelector('.media-controls').classList.contains('inline') is true
-
-PASS successfullyParsed is true
-
-TEST COMPLETE
-
+#EOF
+#EOF
Comment 1 Radar WebKit Bug Importer 2020-06-03 07:20:01 PDT 
<rdar://problem/63925803>
Comment 2 Jason Lawrence 2020-06-03 07:28:45 PDT 
I can reproduce this issue with r262456, but cannot reproduce it with r262455.
Command: run-webkit-tests --iterations 99 --exit-after-n-failures 3 --force -f media/modern-media-controls/media-controller/media-controller-inline-to-fullscreen-to-pip-to-inline.html

r262456 results:
[1/1] media/modern-media-controls/media-controller/media-controller-inline-to-fullscreen-to-pip-to-inline.html failed unexpectedly (test timed out, text diff)
98 tests ran as expected, 1 didn't:

r262455 results:
All 99 tests ran as expected.
Comment 3 Jason Lawrence 2020-06-03 08:45:32 PDT 
I have marked this test as flaky timing out while this issue is investigated.
https://trac.webkit.org/changeset/262488/webkit
Comment 4 Peng Liu 2020-06-03 11:38:21 PDT 
*** Bug 212708 has been marked as a duplicate of this bug. ***
Comment 5 Peng Liu 2020-06-03 11:43:41 PDT 
Created attachment 400949 [details]
Patch
Comment 6 Peng Liu 2020-06-03 11:48:53 PDT 
<rdar://problem/63925803>
Comment 7 EWS 2020-06-03 13:57:48 PDT 
Committed r262514: <https://trac.webkit.org/changeset/262514>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 400949 [details].