| Summary: | dataTransfer.types is empty when handling the "dragstart" event | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Wenson Hsieh <wenson_hsieh> | ||||||
| Component: | HTML Editing | Assignee: | Wenson Hsieh <wenson_hsieh> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | aestes, bdakin, cdumez, esprehn+autocc, ews-watchlist, kangil.han, megan_gardner, mifenton, thorton, webkit-bug-importer, wenson_hsieh | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Wenson Hsieh
2020-06-02 22:25:17 PDT
Created attachment 400900 [details]
For EWS
Comment on attachment 400900 [details] For EWS View in context: https://bugs.webkit.org/attachment.cgi?id=400900&action=review > Source/WebCore/platform/StaticPasteboard.cpp:104 > + m_customData.writeString("text/html", markup); Could append _s to the string literal. > Source/WebCore/platform/StaticPasteboard.cpp:109 > + m_customData.writeString("text/plain", text); Ditto. > Source/WebCore/platform/StaticPasteboard.cpp:114 > + m_customData.writeString("text/uri-list", url.url.string()); Ditto. Comment on attachment 400900 [details] For EWS View in context: https://bugs.webkit.org/attachment.cgi?id=400900&action=review >> Source/WebCore/platform/StaticPasteboard.cpp:104 >> + m_customData.writeString("text/html", markup); > > Could append _s to the string literal. Done! >> Source/WebCore/platform/StaticPasteboard.cpp:109 >> + m_customData.writeString("text/plain", text); > > Ditto. 👍🏻 >> Source/WebCore/platform/StaticPasteboard.cpp:114 >> + m_customData.writeString("text/uri-list", url.url.string()); > > Ditto. 👍🏻 Created attachment 400950 [details]
Patch for landing
Committed r262507: <https://trac.webkit.org/changeset/262507> All reviewed patches have been landed. Closing bug and clearing flags on attachment 400950 [details]. |